Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider for metacyc prefix and consider new prefix for unique IDs #1294

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nagutm
Copy link
Collaborator

@nagutm nagutm commented Dec 6, 2024

PubMed: https://pubmed.ncbi.nlm.nih.gov/39558185/
Database: PlantCyc

This resource has 4 different sematic spaces: Compunds, Reactions, Pathways and Gene/Proteins

The first 3 use the same identifier information from metacyc.compound, metacyc.pathway and metacyc.reaction. They are curated as providers for these resources respectively.

The Gene/Protein subspace seems to have a mix of IDs used.

  • Some of them are TAIR IDs , however the current resolver links on the tair pages in the Bioregistry seem to be outdated and not resolving IDs as expected so I have not curated anything under this prefix until I fix those. example of a tair ID
  • The other category of IDs seem to be unique to this resource with a general pattern of ^G-\d+$. These could be curated as a separate prefix. example of a unique ID

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.62%. Comparing base (8950e70) to head (9f24be8).
Report is 180 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
+ Coverage   42.51%   46.62%   +4.10%     
==========================================
  Files         117      118       +1     
  Lines        8327     8286      -41     
  Branches     1963     1362     -601     
==========================================
+ Hits         3540     3863     +323     
+ Misses       4582     4238     -344     
+ Partials      205      185      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgyori
Copy link
Contributor

bgyori commented Dec 17, 2024

We can get back to this once we know more about #1335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants